Fix generation of JSON path keyvalue() IDs#16482
Merged
electrum merged 1 commit intotrinodb:masterfrom Mar 11, 2023
Merged
Conversation
kasiafi
reviewed
Mar 10, 2023
electrum
force-pushed
the
jsonpath
branch
2 times, most recently
from
974a796 to
1ed13b2
Compare
Previously, separate IDs were generated for each member.
dain
approved these changes
Mar 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, separate IDs were generated for each member.
Note that the tests pass without this fix due to an AssertJ bug that seems to cause the assertion comparisons not to work. This is fixed by upgrading AssertJ in #16420.
Release notes
(x) Release notes are required, with the following suggested text: